Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(promql): add lookback parameter #145

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

etolbakov
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

add lookback parameter to Prometheus proto declarations

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

GreptimeTeam/greptimedb#3630
GreptimeTeam/greptimedb#3453

@etolbakov
Copy link
Contributor Author

@tisonkun could you please check if that's what needed when you have time?

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun requested a review from waynexia April 14, 2024 03:33
@waynexia waynexia merged commit 04d78b6 into GreptimeTeam:main Apr 14, 2024
6 checks passed
MichaelScofield pushed a commit to MichaelScofield/greptime-proto that referenced this pull request Apr 15, 2024
* feat(promql): add lookback parameter

* feat(promql): add lookback parameter to InstantQuery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants