Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ChangeColumnType expr #149

Merged
merged 5 commits into from
Apr 26, 2024
Merged

feat: add ChangeColumnType expr #149

merged 5 commits into from
Apr 26, 2024

Conversation

KKould
Copy link
Contributor

@KKould KKould commented Apr 20, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

add ChnageColumnType on ddl.proto and server.proto

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

GreptimeTeam/greptimedb#3517

@KKould KKould changed the title feat: add ModifyColumn feat: add ModifyColumn expr Apr 20, 2024
@KKould KKould changed the title feat: add ModifyColumn expr feat: add ChangeColumnType expr Apr 24, 2024
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag
Copy link
Contributor

evenyag commented Apr 25, 2024

There are some conflict files.

@evenyag evenyag merged commit 20b85ef into GreptimeTeam:main Apr 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants