Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add json type proto #188

Merged
merged 3 commits into from
Sep 9, 2024
Merged

feat: add json type proto #188

merged 3 commits into from
Sep 9, 2024

Conversation

CookiePieWw
Copy link
Contributor

@CookiePieWw CookiePieWw commented Aug 27, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

GreptimeTeam/greptimedb#4619

What's changed and what's your intention?

Corresponding changes.

May not be needed as GreptimeTeam/greptimedb@092ee0c

It's needed now for distinguish binary and json columns from proto.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may merge this after the DB code is ready.

@WenyXu WenyXu merged commit 973f49c into GreptimeTeam:main Sep 9, 2024
6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants