Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add go protobuf generation #6

Merged
merged 6 commits into from
Feb 15, 2023

Conversation

zyy17
Copy link
Contributor

@zyy17 zyy17 commented Feb 14, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add go protobuf generation.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zyy17
Copy link
Contributor Author

zyy17 commented Feb 14, 2023

Oops... I forget to add protoc-gen-go in protoc installation, and I will add it ASAP.

scripts/generate-go.sh Outdated Show resolved Hide resolved
scripts/install-protoc.sh Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@yuanbohan yuanbohan merged commit 3614737 into GreptimeTeam:main Feb 15, 2023
@zyy17 zyy17 deleted the feat/support-go-project branch February 15, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants