-
Notifications
You must be signed in to change notification settings - Fork 293
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: forgot collect flownode clusterinfo handler (#4236)
* feat: forgot collect flownode clusterinfo handler * fix: unit test * fix: filter stale heartbeat
- Loading branch information
1 parent
fe2c5c3
commit 5d396bd
Showing
5 changed files
with
293 additions
and
263 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
// Copyright 2023 Greptime Team | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use api::v1::meta::{HeartbeatRequest, Role}; | ||
use common_telemetry::warn; | ||
|
||
use super::node_stat::Stat; | ||
use crate::error::Result; | ||
use crate::handler::{HandleControl, HeartbeatAccumulator, HeartbeatHandler}; | ||
use crate::metasrv::Context; | ||
|
||
pub struct ExtractStatHandler; | ||
|
||
#[async_trait::async_trait] | ||
impl HeartbeatHandler for ExtractStatHandler { | ||
fn is_acceptable(&self, role: Role) -> bool { | ||
role == Role::Datanode | ||
} | ||
|
||
async fn handle( | ||
&self, | ||
req: &HeartbeatRequest, | ||
_ctx: &mut Context, | ||
acc: &mut HeartbeatAccumulator, | ||
) -> Result<HandleControl> { | ||
if req.mailbox_message.is_some() { | ||
// If the heartbeat is a mailbox message, it may have no other valid information, | ||
// so we don't need to collect stats. | ||
return Ok(HandleControl::Continue); | ||
} | ||
|
||
match Stat::try_from(req.clone()) { | ||
Ok(stat) => { | ||
let _ = acc.stat.insert(stat); | ||
} | ||
Err(err) => { | ||
warn!(err; "Incomplete heartbeat data: {:?}", req); | ||
} | ||
}; | ||
|
||
Ok(HandleControl::Continue) | ||
} | ||
} |
Oops, something went wrong.