Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests-integration): add a naive region migration integration test #3078

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 3, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Fix heartbeat handler ignore upgrade candidate instruction
  2. Fix handler did not inject wal options
  3. Expose RegionMigrationProcedureTask
  4. Add a naive region migration integration test

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2700

@WenyXu WenyXu added the docs-not-required This change does not impact docs. label Jan 3, 2024
@WenyXu WenyXu self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2e686fe) 85.47% compared to head (e583f72) 85.19%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3078      +/-   ##
==========================================
- Coverage   85.47%   85.19%   -0.29%     
==========================================
  Files         801      805       +4     
  Lines      129967   130724     +757     
==========================================
+ Hits       111095   111373     +278     
- Misses      18872    19351     +479     

@WenyXu WenyXu force-pushed the test/migration-integration-tests branch from cdb2374 to 32ab55c Compare January 3, 2024 05:53
@WenyXu WenyXu requested a review from killme2008 January 3, 2024 06:18
tests-integration/src/cluster.rs Show resolved Hide resolved
tests-integration/src/cluster.rs Show resolved Hide resolved
tests-integration/tests/region_migration.rs Outdated Show resolved Hide resolved
@WenyXu
Copy link
Member Author

WenyXu commented Jan 3, 2024

@killme2008 PTAL

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Jan 3, 2024
Merged via the queue into GreptimeTeam:main with commit 611a8aa Jan 3, 2024
15 checks passed
@WenyXu WenyXu mentioned this pull request Jan 3, 2024
39 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants