-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inverted_index): implement apply for SstIndexApplier #3088
feat(inverted_index): implement apply for SstIndexApplier #3088
Conversation
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
==========================================
- Coverage 85.70% 85.25% -0.45%
==========================================
Files 805 807 +2
Lines 130814 131250 +436
==========================================
- Hits 112117 111902 -215
- Misses 18697 19348 +651 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job!
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR primarily assembles the
SstIndexApplier
, which is capable of applying Puffin Index files based on SST File IDs.Additionally, an
InstrumentedStore
was written to help record some IO metrics.Checklist
Refer to a related PR or issue link (optional)
#2705