Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inverted_index): implement apply for SstIndexApplier #3088

Merged

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Jan 3, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR primarily assembles the SstIndexApplier, which is capable of applying Puffin Index files based on SST File IDs.

Additionally, an InstrumentedStore was written to help record some IO metrics.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2705

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: L labels Jan 3, 2024
@zhongzc zhongzc self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (611a8aa) 85.70% compared to head (eba01eb) 85.25%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
- Coverage   85.70%   85.25%   -0.45%     
==========================================
  Files         805      807       +2     
  Lines      130814   131250     +436     
==========================================
- Hits       112117   111902     -215     
- Misses      18697    19348     +651     

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/mito2/src/metrics.rs Outdated Show resolved Hide resolved
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job!

src/mito2/src/sst/index.rs Show resolved Hide resolved
@killme2008 killme2008 added the A-observability Involves code in the telemetry path label Jan 4, 2024
@zhongzc zhongzc enabled auto-merge January 4, 2024 07:22
@zhongzc zhongzc added this pull request to the merge queue Jan 4, 2024
Merged via the queue into GreptimeTeam:main with commit d973cf8 Jan 4, 2024
22 checks passed
@zhongzc zhongzc deleted the zhongzc/inverted-index-sst-applier branch January 4, 2024 07:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Involves code in the telemetry path docs-not-required This change does not impact docs.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants