Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka): overwrite the EntryId with Offset while consuming records #3148

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 11, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

We don't rely on the EntryId generated by mito2. Instead, we use the offset return from Kafka as EntryId. Therefore, we MUST overwrite the EntryId with RecordOffset.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2700

@WenyXu WenyXu added the docs-not-required This change does not impact docs. label Jan 11, 2024
@WenyXu WenyXu added the O-chaos Found by chaos tests label Jan 11, 2024
@WenyXu WenyXu changed the title fix(kafka): overwrite the EntryId with Offset while consuming the Kaf… fix(kafka): overwrite the EntryId with Offset while consuming records Jan 11, 2024
@WenyXu WenyXu added the O-end-to-end Found by E2E tests label Jan 11, 2024
@WenyXu WenyXu mentioned this pull request Jan 12, 2024
5 tasks
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added Size: S and removed size/xs labels Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ec1e42) 85.41% compared to head (b5f3d96) 84.92%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3148      +/-   ##
==========================================
- Coverage   85.41%   84.92%   -0.49%     
==========================================
  Files         823      823              
  Lines      134797   134927     +130     
==========================================
- Hits       115138   114592     -546     
- Misses      19659    20335     +676     

@evenyag evenyag added this pull request to the merge queue Jan 12, 2024
Merged via the queue into GreptimeTeam:main with commit 430ffe0 Jan 12, 2024
15 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs. O-chaos Found by chaos tests O-end-to-end Found by E2E tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants