Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: RFC of Dataflow Framework #3185

Merged
merged 5 commits into from
Jan 26, 2024
Merged

docs: RFC of Dataflow Framework #3185

merged 5 commits into from
Jan 26, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Jan 17, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Propose to add a dataflow framework for continuous aggregation.
Rendered

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 17, 2024
@waynexia
Copy link
Member

Update corresponding tracking issue to this doc: #3187

docs/rfcs/2024-01-17-dataflow-framework.md Show resolved Hide resolved
docs/rfcs/2024-01-17-dataflow-framework.md Outdated Show resolved Hide resolved
docs/rfcs/2024-01-17-dataflow-framework.md Show resolved Hide resolved
docs/rfcs/2024-01-17-dataflow-framework.md Show resolved Hide resolved
docs/rfcs/2024-01-17-dataflow-framework.md Show resolved Hide resolved
docs/rfcs/2024-01-17-dataflow-framework.md Show resolved Hide resolved
docs/rfcs/2024-01-17-dataflow-framework.md Outdated Show resolved Hide resolved
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM. Could we add some graphics to demonstrate the workflow?

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit d5648c1 Jan 26, 2024
12 checks passed
@fengjiachun fengjiachun deleted the rfc-dataflow branch January 26, 2024 07:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants