Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): impl ScalarExpr&Scalar Function #3283

Merged
merged 14 commits into from
Feb 21, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Feb 5, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add impl for ScalarExpr&Scalar Functions

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Added impl code which eval Unary, Binary and Variadic Func

  • Added utilty functions for ScalarExpr like get supporting(column being used in expression) column for a ScalarExpr.

  • Most importantly, added utility functions for Temporal Filter, which can extract bounding condition including now() function and comparsion expression and express sliding windows etc.

  • Summarize your change (mandatory)
    useful methods for Scalar Expr, and eval method for Scalar function

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: L labels Feb 5, 2024
@discord9 discord9 mentioned this pull request Feb 5, 2024
19 tasks
@discord9 discord9 marked this pull request as ready for review February 5, 2024 08:49
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 296 lines in your changes are missing coverage. Please review.

Comparison is base (c62c67c) 85.64% compared to head (f721059) 85.13%.
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
- Coverage   85.64%   85.13%   -0.52%     
==========================================
  Files         865      884      +19     
  Lines      140798   144751    +3953     
==========================================
+ Hits       120593   123228    +2635     
- Misses      20205    21523    +1318     

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a "flow" scope in the PR title (a.k.a. feat(flow)). It "shocks" me that we don't implement ScalarExpr for GreptimeDB, XD.

@discord9 discord9 changed the title feat: impl ScalarExpr&Scalar Function feat(flow): impl ScalarExpr&Scalar Function Feb 20, 2024
Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/flow/src/expr/scalar.rs Show resolved Hide resolved
@killme2008 killme2008 added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 860b1e9 Feb 21, 2024
17 checks passed
@killme2008 killme2008 deleted the dataflow_p1_impl_map_reduce branch February 21, 2024 13:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants