Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename all datanode_manager to node_manager #3813

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 26, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3664

What's changed and what's your intention?

chore: rename all datanode_manager to node_manager

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested review from MichaelScofield and a team as code owners April 26, 2024 13:42
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 26, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Apr 28, 2024
Merged via the queue into GreptimeTeam:main with commit 3112ced Apr 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants