Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename flow task to flow #3833

Merged
merged 25 commits into from
Apr 29, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 29, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3664

What's changed and what's your intention?

Wait for #3810
Remove all task suffix.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested review from MichaelScofield and a team as code owners April 29, 2024 04:39
@WenyXu WenyXu marked this pull request as draft April 29, 2024 04:39
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 56.56168% with 331 lines in your changes are missing coverage. Please review.

Project coverage is 85.32%. Comparing base (b493ea1) to head (b2b0073).

❗ Current head b2b0073 differs from pull request most recent head dec1360. Consider uploading reports for the commit dec1360 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3833      +/-   ##
==========================================
- Coverage   85.60%   85.32%   -0.28%     
==========================================
  Files         954      954              
  Lines      163072   163038      -34     
==========================================
- Hits       139601   139116     -485     
- Misses      23471    23922     +451     

@WenyXu WenyXu marked this pull request as ready for review April 29, 2024 13:02
src/common/meta/src/key/flow/flow_name.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/flownode_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/flownode_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/rpc/ddl.rs Show resolved Hide resolved
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_flow/check.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/flow_meta.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/flow_meta.rs Show resolved Hide resolved
src/common/meta/src/key.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/table_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/table_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/table_flow.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu enabled auto-merge April 29, 2024 13:52
@WenyXu WenyXu added this pull request to the merge queue Apr 29, 2024
Merged via the queue into GreptimeTeam:main with commit 701aba9 Apr 29, 2024
20 checks passed
@WenyXu WenyXu deleted the feat/create-flow-rename branch April 29, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants