-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: able to handle concurrent region edit requests #4569
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4569 +/- ##
==========================================
+ Coverage 84.83% 84.87% +0.04%
==========================================
Files 1093 1094 +1
Lines 196182 196307 +125
==========================================
+ Hits 166427 166619 +192
+ Misses 29755 29688 -67 |
@evenyag PTAL |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Currently the region edit requests can only be handled one by one. This is because once a region is processing the request, it's set to the "Editing" state, which rejects other concurrent edit requests (require "Writable" state).
This PR adds a "region edit queue" for temporarily storing the concurrent region edit requests. When concurrent requests come in, and the worker loop finds the region is in "Editing" state, it stores the requests in the queue. Once the current edit request is done, the worker loop checks the queue for a remaining edit request and handles it.
Checklist