-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: print frame ip in panic hook #4577
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4577 +/- ##
==========================================
- Coverage 84.88% 84.60% -0.29%
==========================================
Files 1094 1094
Lines 196306 196307 +1
==========================================
- Hits 166639 166086 -553
- Misses 29667 30221 +554 |
Still need more test |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
The default debug format of the backtrace doesn't print the instruction pointer.
https://github.com/rust-lang/backtrace-rs/blob/fd0aed536dd9d6ad1511a4ab3c350409f36ee52a/src/print.rs#L241-L243
https://github.com/rust-lang/backtrace-rs/blob/fd0aed536dd9d6ad1511a4ab3c350409f36ee52a/src/capture.rs#L481-L485
This PR uses the alternative format to print the backtrace so we can still get the address from the log when
strip = true
.Before this PR:
After this PR:
Checklist