-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add fallback_to_local
region option
#4578
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4578 +/- ##
==========================================
- Coverage 84.88% 84.65% -0.23%
==========================================
Files 1094 1096 +2
Lines 196364 196738 +374
==========================================
- Hits 166674 166544 -130
- Misses 29690 30194 +504 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add this key to
greptimedb/src/store-api/src/mito_engine_options.rs
Lines 25 to 26 in 6fccff4
/// Returns true if the `key` is a valid option key for the mito engine. | |
pub fn is_mito_engine_option_key(key: &str) -> bool { |
oops。。。。I forget it again... |
3a0551f
to
125436b
Compare
fallback_to_local_compaction
region optionfallback_to_local
region option
e0ac1d9
to
c6bde49
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add
fallback_to_local
to control whether to fall back to local compaction if remote compaction fails.Checklist