Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHA pipeline, install scipy using conda #604

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Fix GHA pipeline, install scipy using conda #604

merged 5 commits into from
Jul 31, 2023

Conversation

bittner
Copy link
Contributor

@bittner bittner commented Jul 28, 2023

Installing scipy with Pip requires a few prerequisites on the various target platforms. Alternatively, using Conda makes things easier. See StackOverflow for a related discussion.

This is a follow-up on #602.

@bittner
Copy link
Contributor Author

bittner commented Jul 28, 2023

Tests generally run fine against PyPy. Looks like we can keep PyPy in the test matrix, what do you think?

Tests that install scipy fail only on Windows, because Conda is not put on the PATH in GitHub's hosted Windows runners according to their docs. @j-towns Any idea how we could fix that easily?

Any suggestion on how to proceed?

@bittner
Copy link
Contributor Author

bittner commented Jul 29, 2023

@j-towns The CI/CD setup looks complete now. The Python versions supported by GitHub hosted runners are covered.

Known shortcomings:

  • The syntax supported by Pip to install local extras (e.g. pip install '.[scipy]') is not supported by Conda, unfortunately.
  • The root-cause for PyPy 3.7 failing to install numpy is not known and addressed (it looks like an infrastructure issue of the GitHub hosted runner).

Other than that this PR is ready to be merged, IMHO.

@bittner bittner changed the title Install scipy using conda Fix GHA pipeline, install scipy using conda Jul 29, 2023
@j-towns j-towns merged commit 2f8e00d into HIPS:master Jul 31, 2023
49 checks passed
@j-towns
Copy link
Collaborator

j-towns commented Jul 31, 2023

Looks great, thanks!

@j-towns
Copy link
Collaborator

j-towns commented Jul 31, 2023

Hmm actually I think there is still an issue with SciPy. It looks as though it is being installed globally when it should be, but then this warning indicates it is not being found by import scipy, and I think that's because it's not being included in the environment that tox sets up. I'm not sure how to fix this.

@bittner bittner deleted the fix/scipy-installation branch July 31, 2023 14:05
@bittner
Copy link
Contributor Author

bittner commented Jul 31, 2023

Hmm actually I think there is still an issue with SciPy. It looks as though it is being installed globally when it should be, but then this warning indicates it is not being found by import scipy, and I think that's because it's not being included in the environment that tox sets up. I'm not sure how to fix this.

True. This is most certainly because we're mixing Conda and Pip + virtualenv.

We might try to install scipy globally and make sure that shines through in the provisioned virtual environments. IIRC, there is a related Tox configuration switch for that.

Trying Conda for everything failed when I tried it during this PR. We might try that again, though, and figure out why Tox didn't like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants