Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Remove python 3.7 runners from test workflow. #624

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[ci] Remove python 3.7 runners from test workflow. #624

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92a7e9e
[ci] Remove python 3.7 runners from test workflow.
fjosw Jul 26, 2024
dec087d
[ci] Remove python 3.8 from the test workflow and add 3.12 instead.
fjosw Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,13 @@ jobs:
- macos-latest
- windows-latest
python-version:
- '3.7'
- '3.8'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- '3.8'

Copy link
Collaborator Author

@fjosw fjosw Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think after merging #618 python 3.8 should still work with numpy<2.0 as the changes are backward compatible. But as python 3.8 will be obsolete soon I'm fine with removing it from the ci right away. I will push an update soon.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of removing python 3.8 I now also added python 3.12.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the explanation!

- '3.9'
- '3.10'
- '3.11'
- pypy-3.7
- pypy-3.8
- pypy-3.9
- pypy-3.10
exclude:
- { platform: windows-latest, python-version: pypy-3.7 }
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
Expand Down
Loading