Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the release workflow #627

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

agriyakhetarpal
Copy link
Collaborator

Description

Stemmed off from #618. This updates the release workflow prior to triggering a new v1.7.0 release.

Changes made

  1. Better coloured output: FORCE_COLOR: environment variable set to 3
  2. Workflow will now not be triggered from a tag but from a GitHub Release made from said tag (gives better control in case a tag is created and pushed to GitHub in haste)
  3. Uses pypa/build to build the sdist and then the wheel from the sdist
  4. Some bumps to GitHub Actions versions
  5. The build and upload steps are now isolated, sharing artifacts. They are integrated with varying permissions to enhance security in the advent of events from malicious actors. The PyPI upload step uses the environment set in the repository settings and trusted publishing has been set up by @j-towns on the PyPI portal. The PyPI upload action runs twine internally with the strict option to check the sdist and wheel. It is pinned to the commit hash for the latest release at the time of writing (v1.9.0).

@agriyakhetarpal
Copy link
Collaborator Author

I shall take a look at the failing PyPy tests in a short moment

@agriyakhetarpal
Copy link
Collaborator Author

I faced the Pythran error in other repositories today and reported it a while earlier: pypa/setuptools#4579. It has been fixed with setuptools version 73.0.1, so I re-triggered the PyPy jobs. Please let me know if anything else is needed for the release after we merge this!

@agriyakhetarpal agriyakhetarpal merged commit c790f00 into master Aug 20, 2024
18 checks passed
@agriyakhetarpal agriyakhetarpal deleted the chore/release-workflow branch August 20, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants