Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Run test workflow at the beginning of every month and enable manual trigger of the pipeline. #629

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

fjosw
Copy link
Collaborator

@fjosw fjosw commented Aug 23, 2024

At least for now I think it can be useful to trigger the test pipeline automatically once every month to spot any problems. I also propose to add workflow_dispatch which allows us to manually trigger a run via the GitHub UI without having to push a commit.

Copy link
Collaborator

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fjosw, thanks! Once every month sounds a little too less to me; I would instead suggest running it every night – the earlier we can catch upstream breakages, the better. However, I agree that workflow_dispatch: is quite beneficial to add.

.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better, thanks!

@agriyakhetarpal agriyakhetarpal merged commit c9acadc into HIPS:master Aug 23, 2024
18 checks passed
@fjosw fjosw deleted the ci/add_manual_trigger branch August 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants