Implement set_text_utf16. #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
khaledhosny
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm rewriting the svg text layout for Krita, using libraqm as a base. I've gotten pretty far with it, however there's a number of smaller things that make more sense to implement in raqm itself.
The first of these is that our toolkit, Qt, uses utf16 for the strings by default, and while I can convert the strings to utf8 or utf32, keeping track of the string length and which encoding it's in is a bit of a drag, especially as raqm is already doing that for utf8. So I implemented utf16 functions in addition to the utf8 ones.
I had a bit of trouble deciding on how to tackle the tests. Right now, it seems the tests are always testing utf8? Any idea on how to approach this?