Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added balancing groups and common group receiver #2885

Draft
wants to merge 100 commits into
base: master
Choose a base branch
from

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Feb 21, 2024

Draft until #2527

Mikołaj Małecki and others added 30 commits July 29, 2022 12:44
…. Fixed epoll usage for reception for groups.
srtcore/buffer_rcv.cpp Fixed Show fixed Hide fixed
srtcore/group.h Fixed Show fixed Hide fixed
@@ -126,6 +127,7 @@
for (int i = 0; i < iNumUnits; ++i)
{
tempu[i].m_bTaken = false;
tempu[i].m_pParentQueue = this;

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory Warning

A stack address which arrived via a
parameter
may be assigned to a non-local variable.
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 78.98734% with 83 lines in your changes missing coverage. Please review.

Project coverage is 63.84%. Comparing base (4f925fb) to head (328c359).
Report is 11 commits behind head on master.

Current head 328c359 differs from pull request most recent head 2e182a8

Please upload reports for the commit 2e182a8 to get more accurate results.

Files Patch % Lines
srtcore/buffer_rcv.cpp 71.93% 55 Missing ⚠️
srtcore/group.h 66.66% 12 Missing ⚠️
srtcore/list.cpp 94.56% 5 Missing ⚠️
srtcore/buffer_rcv.h 50.00% 4 Missing ⚠️
srtcore/api.cpp 50.00% 2 Missing ⚠️
srtcore/group_common.cpp 50.00% 2 Missing ⚠️
srtcore/group_common.h 0.00% 2 Missing ⚠️
srtcore/queue.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2885      +/-   ##
==========================================
- Coverage   64.88%   63.84%   -1.04%     
==========================================
  Files         101      102       +1     
  Lines       17634    18322     +688     
==========================================
+ Hits        11441    11698     +257     
- Misses       6193     6624     +431     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ethouris and others added 3 commits February 28, 2024 11:03
(further impossible fixes pending)

Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
@maxsharabayko maxsharabayko added this to the Major milestone Mar 6, 2024
@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [core] Area: Changes in SRT library core labels Mar 6, 2024
@Dawiducik
Copy link

That feature looks so cool! Is there any timeline when the next major version of SRT will be published along with this?

Comment on lines 452 to 468
/*
const T& operator[](int index) const
{
if (index < 0 || static_cast<size_t>(index) >= m_size)
throw_invalid_index(index);

return m_entries[index];
}

T& operator[](int index)
{
if (index < 0 || static_cast<size_t>(index) >= m_size)
throw_invalid_index(index);

return m_entries[index];
}
*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants