Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown | Add searching (with callbacks) #185

Closed
aVileBroker opened this issue Oct 14, 2020 · 0 comments · Fixed by #296
Closed

Dropdown | Add searching (with callbacks) #185

aVileBroker opened this issue Oct 14, 2020 · 0 comments · Fixed by #296
Assignees
Labels
3 Story Points 3 Story Points enhancement New feature or request

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented Oct 14, 2020

We should have a default internal search which sorts the current option list, which can be turned off and onChange callbacks (also pass the onDebouncedChange callback up as a separate function)

I like to use fuse.basic.js for fuzzy searching lists on client-side. It weights the results and allows for mispellings, searching multiple properties in a nested object, and weights for each property in nested objects. It also returns where in the strings the matches occur so that we can highlight/bold the letters which match the search.

The API could be

  • searchable
  • searchFiltersOptions (needs a better name - but this would be what tells us to filter the list ourselves, and add the boldness to the matched patterns)
  • onSearchChange
  • onDebouncedSearchChange
@aVileBroker aVileBroker added enhancement New feature or request 2 Story Points 2 Story Points labels Oct 14, 2020
@j-storey5 j-storey5 self-assigned this Aug 3, 2021
@aVileBroker aVileBroker added 3 Story Points 3 Story Points and removed 2 Story Points 2 Story Points labels Aug 16, 2021
@pwheadstorm pwheadstorm reopened this Aug 16, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
Add an input to fuzzy search and filter the dropdown options

Headstorm#185
@dawsonbooth dawsonbooth linked a pull request Aug 20, 2021 that will close this issue
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 24, 2021
dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 24, 2021
aVileBroker added a commit that referenced this issue Aug 24, 2021
HeadstormOps pushed a commit that referenced this issue Aug 24, 2021
…08-24)

### Features

* **dropdown:** add searching (with callbacks) ([d1e9237](d1e9237)), closes [#185](#185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Story Points 3 Story Points enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants