Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown | open upward when space below is limited #187

Closed
2 tasks
aVileBroker opened this issue Oct 14, 2020 · 1 comment · Fixed by #282
Closed
2 tasks

Dropdown | open upward when space below is limited #187

aVileBroker opened this issue Oct 14, 2020 · 1 comment · Fixed by #282
Assignees
@harrisonnoble
Labels
2 Story Points 2 Story Points enhancement New feature or request help wanted Extra attention is needed released

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented Oct 14, 2020 •
edited
Loading

AC:

  • When near the bottom of the window, the dropdown should open upward
  • Add prop to prevent this behavior if desired (flipDirectionToStayInView or something, default to true)
@aVileBroker aVileBroker added the enhancement New feature or request label Oct 14, 2020
@aVileBroker aVileBroker added 1 Story Point Story points: 1 help wanted Extra attention is needed labels Aug 2, 2021
@aVileBroker aVileBroker added 2 Story Points 2 Story Points and removed 1 Story Point Story points: 1 labels Aug 5, 2021
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 9, 2021
Headstorm#187 functionality and styling for dropdown opening upward, …
b94fd4d 
…flickering issue when dropdown does not fit in viewport
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 9, 2021
feat(dropdown): added functionality to change direction of dropdown m…
28f5203 
…enu based on viewport bounds

Headstorm#187
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 9, 2021
Headstorm#187 all tests passing, dropdown changes direction based on …
1fe7fb6 
…available space in viewport
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 9, 2021
Headstorm#187 all tests passing, dropdown changes direction based on …
224794b 
…available space in viewport, prop added to control this functionality
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 9, 2021
Headstorm#187 all tests passing, dropdown changes direction based on …
906325f 
…available space in viewport, isAware prop added to control this functionality
@harrisonnoble harrisonnoble mentioned this issue Aug 9, 2021
Merged
@harrisonnoble harrisonnoble self-assigned this Aug 12, 2021
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 13, 2021
Headstorm#187 working on additional tests for dropdown
8eabb2a
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 13, 2021
Headstorm#187 still working on additional tests for dropdown
1a27a4d
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 13, 2021
Headstorm#187 working on tests for dropdown
983a760
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 13, 2021
Headstorm#187 tests are ~passing~ but not correct
d74dba4
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 13, 2021
Headstorm#187 still working on final tests, snapshots not rendering c…
a774468 
…orrectly
harrisonnoble pushed a commit to harrisonnoble/foundry-ui that referenced this issue Aug 13, 2021
Headstorm#187 still working on final tests, snapshots not rendering c…
0da4be7 
…orrectly
harrisonnoble added a commit to harrisonnoble/foundry-ui that referenced this issue Aug 16, 2021
@harrisonnoble
Headstorm#187 working on merge conflicts
a59083b
harrisonnoble added a commit to harrisonnoble/foundry-ui that referenced this issue Aug 17, 2021
@harrisonnoble
Headstorm#187 done
ee7f2bc
harrisonnoble added a commit to harrisonnoble/foundry-ui that referenced this issue Aug 17, 2021
@harrisonnoble
Headstorm#187 deleted coverage
58533fb
harrisonnoble added a commit to harrisonnoble/foundry-ui that referenced this issue Aug 17, 2021
@harrisonnoble
Headstorm#187 small changes
0eaf6ac
harrisonnoble added a commit to harrisonnoble/foundry-ui that referenced this issue Aug 17, 2021
@harrisonnoble
Headstorm#187 small changes v2
533d0be
harrisonnoble added a commit that referenced this issue Aug 17, 2021
@harrisonnoble
Merge pull request #282 from harrisonnoble/187-dropdown-open-upward
332e159 
#187 Dropdown open upward
HeadstormOps pushed a commit that referenced this issue Aug 17, 2021
@semantic-release-bot
chore(release): 1.9.0 [skip ci]nn# [1.9.0](v1.8.0...v1.9.0) (2021-08-17)
440fd16 
### Features

* **dropdown:** added functionality to change direction of dropdown menu based on viewport bounds ([28f5203](28f5203)), closes [#187](#187)
@HeadstormOps
Copy link

🎉 This issue has been resolved in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

dawsonbooth added a commit to dawsonbooth/foundry-ui that referenced this issue Aug 20, 2021
@dawsonbooth
Headstorm#187 Add prop for custom intersection container
d6434b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrisonnoble harrisonnoble

Labels
2 Story Points 2 Story Points enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#187 Dropdown open upward harrisonnoble/foundry-ui
3 participants
@aVileBroker @harrisonnoble @HeadstormOps