Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown | selected checkmark when isMulti is nearly invisible when optionsVariant is outline #242

Closed
aVileBroker opened this issue Jul 13, 2021 · 1 comment · Fixed by #243
Closed

Dropdown | selected checkmark when isMulti is nearly invisible when optionsVariant is outline #242

aVileBroker opened this issue Jul 13, 2021 · 1 comment · Fixed by #243
Assignees
@aVileBroker
Labels
0.5 Story Points issue size: .5 bug Something isn't working released

Comments

@aVileBroker
Copy link
Contributor

As seen here:
image

The checkmark color is nearly the same as the selected background instead of the text color.

Expected: The checkmark color should match the text color exactly.
@aVileBroker aVileBroker added enhancement New feature or request bug Something isn't working 0.5 Story Points issue size: .5 and removed enhancement New feature or request labels Jul 13, 2021
@aVileBroker aVileBroker self-assigned this Jul 13, 2021
aVileBroker added a commit to aVileBroker/foundry-ui that referenced this issue Jul 13, 2021
@aVileBroker
fix(dropdown.tsx): set color of selected option's checkmark to match …
aa78d66 
…its text color

When selected in certain color/variant combinations the checkmark color of a selecte multiselect
option was nearly invisible due to a 50% tint. This change sets the checkmark color match the color
of the options text to eliminate any contrast issues in the future.

fix Headstorm#242
@aVileBroker aVileBroker mentioned this issue Jul 13, 2021
Merged
HeadstormOps pushed a commit that referenced this issue Jul 15, 2021
@semantic-release-bot
chore(release): 1.0.6 [skip ci]nn## [1.0.6](v1.0.5...v1.0.6) (2021-07…
62b1f00 
…-15)

### Bug Fixes

* **dropdown.tsx:** don't show scrollbars on dropdowns if they don't need to scroll ([20c2a12](20c2a12))
* **dropdown.tsx:** set color of selected option's checkmark to match its text color ([aa78d66](aa78d66)), closes [#242](#242)
@HeadstormOps
Copy link

🎉 This issue has been resolved in version 1.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aVileBroker aVileBroker

Labels
0.5 Story Points issue size: .5 bug Something isn't working released
Projects
None yet
Milestone
No milestone
2 participants
@aVileBroker @HeadstormOps