Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown | Clearing values opens the dropdown #288

Closed
aVileBroker opened this issue Aug 12, 2021 · 1 comment · Fixed by #298
Closed

Dropdown | Clearing values opens the dropdown #288

aVileBroker opened this issue Aug 12, 2021 · 1 comment · Fixed by #298
Labels
0.5 Story Points issue size: .5 bug Something isn't working released

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented Aug 12, 2021 •
edited
Loading

It doesn't seem to open the dropdown by focusing as blur events don't close it.

Either way it shouldn't open the dropdown when clicked.

Clicking on the down/up arrow also doesn't trigger the interaction feedback splash as you'd expect, the arrow shouldn't capture anything - it may as well have no pointer events

AC:

  • evt.preventDefault (or stopPropagation) on click of the clear button (probably in an onClear function)
  • Set the pointer-events css rule to none on the arrow.
@aVileBroker aVileBroker added bug Something isn't working 0.5 Story Points issue size: .5 labels Aug 12, 2021
jon3b pushed a commit to jon3b/foundry-ui that referenced this issue Aug 20, 2021
fix(dropdown): stop clear icon from opening dropdown and remove point…
f29fa05 
…er options from arrow icon

Change clear icon functionality so that dropdown list doesn't open after value is cleared. Arrow
icon CSS updated to remove pointer options so that ripple effect functionality is uniform across
entire dropdown button

fix Headstorm#288
@jon3b jon3b mentioned this issue Aug 20, 2021
Merged
HeadstormOps pushed a commit that referenced this issue Aug 20, 2021
@semantic-release-bot
chore(release): 1.9.1 [skip ci]nn## [1.9.1](v1.9.0...v1.9.1) (2021-08…
e53cf5f 
…-20)

### Bug Fixes

* **dropdown:** stop clear icon from opening dropdown and remove pointer options from arrow icon ([f29fa05](f29fa05)), closes [#288](#288)
@HeadstormOps
Copy link

🎉 This issue has been resolved in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.5 Story Points issue size: .5 bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

288 dropdown clearing values jon3b/foundry-ui
3 participants
@aVileBroker @j-storey5 @HeadstormOps