Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button | can't override props for left/right icon containers #330

Closed
aVileBroker opened this issue Sep 11, 2021 · 0 comments · Fixed by #347
Closed

Button | can't override props for left/right icon containers #330

aVileBroker opened this issue Sep 11, 2021 · 0 comments · Fixed by #347
Assignees
@PatrickDeVries
Labels
0.5 Story Points issue size: .5 bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aVileBroker
Copy link
Contributor

Button accepts a container and ref for both icon containers, but no props objects.

One reason to have this is to be able to set the "size" prop on the Icon component to set the size of the icon without targeting the svg with css from the container
@aVileBroker aVileBroker added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed 0.5 Story Points issue size: .5 labels Sep 11, 2021
@PatrickDeVries PatrickDeVries self-assigned this Oct 27, 2021
PatrickDeVries added a commit to PatrickDeVries/foundry-ui that referenced this issue Oct 27, 2021
@PatrickDeVries
feat(button): add prop support for Button icons
490705a 
Add left icon props and right icon props props to allow easy override of their values

ref Headstorm#330
@PatrickDeVries PatrickDeVries linked a pull request Oct 27, 2021 that will close this issue
330 Support for icon props in Button #347
Merged
HeadstormOps pushed a commit that referenced this issue Nov 4, 2021
@semantic-release-bot
chore(release): 1.14.0 [skip ci]nn# [1.14.0](v1.13.1...v1.14.0) (2021…
167aec5 
…-11-04)

### Features

* **button:** add prop support for Button icons ([490705a](490705a)), closes [#330](#330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PatrickDeVries PatrickDeVries

Labels
0.5 Story Points issue size: .5 bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

330 Support for icon props in Button PatrickDeVries/foundry-ui
2 participants
@aVileBroker @PatrickDeVries