Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextInput | clearable X no longer works #355

Closed
aVileBroker opened this issue Nov 16, 2021 · 1 comment · Fixed by #363
Closed

TextInput | clearable X no longer works #355

aVileBroker opened this issue Nov 16, 2021 · 1 comment · Fixed by #363
Assignees
@aVileBroker
Labels
0.5 Story Points issue size: .5 bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed released

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented Nov 16, 2021 •
edited
Loading

Adding the clearable flag will add the X button - but it does nothing when clicked (doesn't call the onClear function either)

This should have been caught by unit tests so if there isn't one already, make sure this functionality is tested so we don't get further regressions.
@aVileBroker aVileBroker added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed 0.5 Story Points issue size: .5 labels Nov 16, 2021
@aVileBroker aVileBroker self-assigned this Dec 1, 2021
aVileBroker added a commit that referenced this issue Dec 3, 2021
@aVileBroker
fix(textinput): fix onclear for uncontrolled and controlled TextInputs
2558829 
This fix comes with several tests to cover events like onChange and onClear - as well as some minor
style changes. It also changes the clear icon to be a Button.

fixes #355 fixes #356 fixes #357
@aVileBroker aVileBroker linked a pull request Dec 3, 2021 that will close this issue
Fixes #355 Fixes #356 Fixes #357 text input improvements #363
Merged
aVileBroker added a commit that referenced this issue Dec 3, 2021
@aVileBroker
Merge pull request #363 from Headstorm/355-356-357-text-input-improve…
9461931 
…ments

Fixes #355 Fixes #356 Fixes #357 text input improvements
HeadstormOps pushed a commit that referenced this issue Dec 3, 2021
@semantic-release-bot
chore(release): 1.14.3 [skip ci]nn## [1.14.3](v1.14.2...v1.14.3) (202…
7136630 
…1-12-03)

### Bug Fixes

* **textinput:** Change TextInput icon cursor from 'pointer' to 'text' ([8c47466](8c47466))
* **textinput:** fix onclear for uncontrolled and controlled TextInputs ([2558829](2558829)), closes [#355](#355) [#356](#356) [#357](#357)
@HeadstormOps
Copy link

🎉 This issue has been resolved in version 1.14.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aVileBroker aVileBroker

Labels
0.5 Story Points issue size: .5 bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #355 Fixes #356 Fixes #357 text input improvements Headstorm/foundry-ui
2 participants
@aVileBroker @HeadstormOps