Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spotlight | Reactions to scrolling/window resize shouldn't smoothly animate #360

Closed
aVileBroker opened this issue Nov 24, 2021 · 1 comment
Closed

Spotlight | Reactions to scrolling/window resize shouldn't smoothly animate #360

aVileBroker opened this issue Nov 24, 2021 · 1 comment
Assignees
@aVileBroker
Labels
0.5 Story Points issue size: .5 enhancement New feature or request help wanted Extra attention is needed released

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented Nov 24, 2021 •
edited
Loading

Currently when scrolling while the spotlight is targeting an element, the spotlight will smoothly animate to the new position - which makes it feel like it's lagging behind. Ideally it should just scroll with the page contents. The same happens when the screensize changes

Dev hint: The useMemo for the spotlight rectangle bounds can update as usual, but the useSpring config needs to be set() with immediate: true when it is triggered by a scroll.
@aVileBroker aVileBroker added enhancement New feature or request help wanted Extra attention is needed 0.5 Story Points issue size: .5 labels Nov 24, 2021
@aVileBroker aVileBroker changed the title Spotlight | Reactions to scrolling shouldn't smoothly animate Spotlight | Reactions to scrolling/window resize shouldn't smoothly animate Apr 12, 2022
@aVileBroker aVileBroker self-assigned this May 3, 2022
aVileBroker added a commit that referenced this issue May 4, 2022
@aVileBroker
Merge pull request #387 from aVileBroker/360-spotlight-scroll-resize
2312d7a 
Fixes #360 Stop spotlight from animating during scroll and resize events
HeadstormOps pushed a commit that referenced this issue May 4, 2022
@semantic-release-bot
chore(release): 1.16.1 [skip ci]nn## [1.16.1](v1.16.0...v1.16.1) (202…
9f713a6 
…2-05-04)

### Bug Fixes

* **spotlight:** spotlight now smoothly animates only when switching target and not on scroll/resize ([9c8f763](9c8f763)), closes [#360](#360)
@HeadstormOps
Copy link

🎉 This issue has been resolved in version 1.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aVileBroker aVileBroker

Labels
0.5 Story Points issue size: .5 enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aVileBroker @HeadstormOps