Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown | Add ability for placeholder to persist after values are selected #449

Closed
aVileBroker opened this issue Jul 10, 2023 · 0 comments
Closed

Dropdown | Add ability for placeholder to persist after values are selected #449

aVileBroker opened this issue Jul 10, 2023 · 0 comments
Labels
0.5 Story Points issue size: .5 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aVileBroker
Copy link
Contributor

AC

  • Allow placeholder to overwrite valueItemsContainer
@aVileBroker aVileBroker added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed 0.5 Story Points issue size: .5 labels Jul 10, 2023
@j-leidy j-leidy mentioned this issue Jul 13, 2023
Merged
j-leidy added a commit to j-leidy/foundry-ui that referenced this issue Jul 17, 2023
@j-leidy
feat(dropdown.tsx): modified placeholder logic again
a197895 
feat Headstorm#449
j-leidy added a commit to j-leidy/foundry-ui that referenced this issue Jul 17, 2023
@j-leidy
feat(dropdown.tsx): removing a console log
2e69f32 
feat Headstorm#449
j-leidy added a commit to j-leidy/foundry-ui that referenced this issue Jul 18, 2023
@j-leidy
feat(dropdown.tsx): left multi in logic, removed and checked function…
ca68fc0 
…ality of blur

feat Headstorm#449
j-leidy added a commit to j-leidy/foundry-ui that referenced this issue Jul 18, 2023
@j-leidy
feat(dropdown.tsx): another reduction to blurring logic
b114578 
feat Headstorm#449
j-leidy added a commit to j-leidy/foundry-ui that referenced this issue Jul 18, 2023
@j-leidy
feat(dropdown.tsx): made logical statement shorter, reverified blur f…
5abcf09 
…ucntionliaty

when swapping between the 8 combinations of searchable,placeholder,multi

feat Headstorm#449
j-leidy added a commit to j-leidy/foundry-ui that referenced this issue Jul 18, 2023
@j-leidy
feat(dropdown.tsx): improved naming to make code more readable
9f9d925 
feat Headstorm#449
HeadstormOps pushed a commit that referenced this issue Jul 18, 2023
@semantic-release-bot
chore(release): 1.25.0 [skip ci]nn# [1.25.0](v1.24.0...v1.25.0) (2023…
0017080 
…-07-18)

### Features

* **dropdown.tsx dropdown.stories.tsx:** removed showCloseIcon prop, replaced with clearable ([5b2d0a8](5b2d0a8)), closes [#451](#451)
* **dropdown.tsx:** another reduction to blurring logic ([b114578](b114578)), closes [#449](#449)
* **dropdown.tsx:** fixing blurring, placeholder persist ([7202f26](7202f26))
* **dropdown.tsx:** improved naming to make code more readable ([9f9d925](9f9d925)), closes [#449](#449)
* **dropdown.tsx:** left multi in logic, removed and checked functionality of blur ([ca68fc0](ca68fc0)), closes [#449](#449)
* **dropdown.tsx:** made logical statement shorter, reverified blur fucntionliaty ([5abcf09](5abcf09)), closes [#449](#449)
* **dropdown.tsx:** modified logic for displaying count & close icon, made requested changes ([9214047](9214047)), closes [#451](#451)
* **dropdown.tsx:** modified placeholder logic again ([a197895](a197895)), closes [#449](#449)
* **dropdown.tsx:** removed unnecessary logic in blurring ([a99add3](a99add3))
* **dropdown.tsx:** removing a console log ([2e69f32](2e69f32)), closes [#449](#449)
* **dropdown.tsx:** updated snapshots ([d1223b7](d1223b7)), closes [#451](#451)
* **dropdown.tsx:** updated snapshots ([7fde800](7fde800)), closes [#451](#451)
* **dropdown.tsx:** variant Support, show count, show close, show both, style-able, prop-able ([36ee394](36ee394)), closes [#451](#451)
* snapshots ([74648b1](74648b1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.5 Story Points issue size: .5 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Foundry-React-UI
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aVileBroker