Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spotlight | Scroll to element if not visible #476

Closed
5 tasks
aVileBroker opened this issue Oct 6, 2023 · 1 comment · Fixed by #477
Closed
5 tasks

Spotlight | Scroll to element if not visible #476

aVileBroker opened this issue Oct 6, 2023 · 1 comment · Fixed by #477
Assignees
@aVileBroker
Labels
1 Story Point Story points: 1 enhancement New feature or request released

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented Oct 6, 2023 •
edited
Loading

AC

  • Use the Intersection Observer API to figure out if its off screen
  • figure out the scroll position
  • scroll to position
  • use custom element if the body isn't what gets scrolled in the app (or walk up the DOM to find the scrollable container??)
  • include a scroll padding attribute to set how much extra space to give the element on top of its scroll position so it doesn't literally touch it
@aVileBroker aVileBroker added enhancement New feature or request 1 Story Point Story points: 1 labels Oct 6, 2023
@aVileBroker aVileBroker self-assigned this Oct 6, 2023
@aVileBroker aVileBroker linked a pull request Oct 9, 2023 that will close this issue
Fixes #476 Smooth scrolling to new target's location #477
Merged
aVileBroker added a commit that referenced this issue Oct 12, 2023
@aVileBroker
Merge pull request #478 from GarrettRathke/476-spotlight-scrolling
5e5a16b 
Fixes #476 Smooth scrolling to new target's location
HeadstormOps pushed a commit that referenced this issue Oct 12, 2023
@semantic-release-bot
chore(release): 1.27.3 [skip ci]nn## [1.27.3](v1.27.2...v1.27.3) (202…
84abc33 
…3-10-12)

### Bug Fixes

* **spotlight:** spotlight now scrolls to new targets if they are scrolled out of view ([8d7776a](8d7776a)), closes [#476](#476)
@HeadstormOps
Copy link

🎉 This issue has been resolved in version 1.27.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aVileBroker aVileBroker

Labels
1 Story Point Story points: 1 enhancement New feature or request released
Projects
Foundry-React-UI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #476 Smooth scrolling to new target's location Headstorm/foundry-ui
2 participants
@aVileBroker @HeadstormOps