Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtualize dropdown options list #284

Merged
merged 21 commits into from
Aug 12, 2021
Merged

Virtualize dropdown options list #284

merged 21 commits into from
Aug 12, 2021

Commits on Aug 9, 2021

  1. Prevent generating duplicate cities

    @dawsonbooth
    dawsonbooth committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    e6aad39 View commit details
    Browse the repository at this point in the history

  2. Show value in onSelect action

    @dawsonbooth
    dawsonbooth committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    80ce173 View commit details
    Browse the repository at this point in the history

  3. Fix placeholder for Icons story

    @dawsonbooth
    dawsonbooth committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    0004a9b View commit details
    Browse the repository at this point in the history

  4. feat(dropdown): virtualize options list for better performance of lon… 

    …g lists

Use `react-virtuoso` to virtualize the option items in the dropdown. This is done to reduce the
amount of time to render the initial view and process updates.

fix Headstorm#184
    @dawsonbooth
    dawsonbooth committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    805ed04 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into 184-virtual-dropdown

    @dawsonbooth
    dawsonbooth committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    3981619 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Headstorm#184 Fix keyboard navigation

    @dawsonbooth
    dawsonbooth committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    37802f2 View commit details
    Browse the repository at this point in the history

  2. Headstorm#184 Set initialItemCount to pass tests

    @dawsonbooth
    dawsonbooth committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    a66adf5 View commit details
    Browse the repository at this point in the history

  3. Fix duplicate options prevention

    @dawsonbooth
    dawsonbooth committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    059d4fe View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Headstorm#184 Only virtualize options when DOM is available

    @dawsonbooth
    dawsonbooth committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    8727658 View commit details
    Browse the repository at this point in the history

  2. Fix dropdown stories style and performance

    @dawsonbooth
    dawsonbooth committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    c0167d5 View commit details
    Browse the repository at this point in the history

  3. Headstorm#184 Modify number of options to render initially

    @dawsonbooth
    dawsonbooth committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    449bf70 View commit details
    Browse the repository at this point in the history

  4. Headstorm#184 Remember scroll position after close

    @dawsonbooth
    dawsonbooth committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    cfa9fca View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Headstorm#184 Remove virtualization if less than max height

    @dawsonbooth
    dawsonbooth committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    e32d398 View commit details
    Browse the repository at this point in the history

  2. Headstorm#184 Adjust naming for nested elements on keypress

    @dawsonbooth
    dawsonbooth committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    f79835e View commit details
    Browse the repository at this point in the history

  3. Improve city option item variable naming

    @dawsonbooth
    dawsonbooth committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    823cb18 View commit details
    Browse the repository at this point in the history

  4. Improve performance of city option generation

    @dawsonbooth
    dawsonbooth committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    2aa71d2 View commit details
    Browse the repository at this point in the history

  5. Headstorm#184 Add state for whether to virtualize options

    @dawsonbooth
    dawsonbooth committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    004ed15 View commit details
    Browse the repository at this point in the history

  6. Headstorm#184 Refactor keypress handler and nested scroller

    @dawsonbooth
    dawsonbooth committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    ffe6cb3 View commit details
    Browse the repository at this point in the history

  7. Headstorm#184 Remember scroll position for non-virtual list

    @dawsonbooth
    dawsonbooth committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    31fcd45 View commit details
    Browse the repository at this point in the history

  8. Headstorm#184 Remove extra timeout and document navigation

    @dawsonbooth
    dawsonbooth committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    11e7cd4 View commit details
    Browse the repository at this point in the history

  9. Headstorm#184 Add open/close timeout to improve performance

    @dawsonbooth
    dawsonbooth committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    2c9c7a0 View commit details
    Browse the repository at this point in the history