-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new Layers Panel icons take focus away from editor #387
Comments
Ah, in the previous version selecting an item in the layers panel must have set focus on the particular window, now in this latest version that doesn't happen. |
it is SUPPOSED to... but the binding between selecting something in the layers and focus ending up on the visual editor is very indirect (the original code really likes handling collection change events instead of just calling functions ;)) so yeah it is possible there are some paths now where the focus is lost. It is not acting the way I would prefer. But if that's all it is, then it isn't gonna blow up on us |
Looking into it a bit further, if i open the editor and manually unlock items then clicking in the layers panel always sets focus. However after using Unlock All even only once then focus is never set whether an item is manually unlocked or globally unlocked throughout the whole profile until Helios is restarted. Unlock and Unlock All are making some global change in Helios until it is restarted. |
ok great. having a reproducible test case like that greatly increases the chance I will fix it :) |
blue selection indicates the keyboard focus is on that editor, which is why the delete key works the icons bar in the layers panel needs to not take keyboard focus when used, because Helios relies on the keyboard focus remaining on the visual editor |
this is required to allow keyboard focus to remain with visual editor while manipulating layers fixes #387
released as 3425 |
Helios version 1.6.3424.0000
Selecting a layer in the layers panel and pressing the delete key randomly fails to delete the layer. After restarting Helios the delete key works again. It seems to fail after using one of the new "lock all" and "unlock all" selection buttons at the top of the layers panel.
The text was updated successfully, but these errors were encountered: