Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-8B Composite gauges broken at 1.6.5011 #486

Closed
BlueFinBima opened this issue Nov 9, 2021 · 3 comments
Closed

AV-8B Composite gauges broken at 1.6.5011 #486

BlueFinBima opened this issue Nov 9, 2021 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BlueFinBima
Copy link

Reported by Torattacker on Discord as the AV-8BV4 profile not working, however simplest test case is to use the Master Arm Panel from the AV-8B Gauges toolbox bound to the AV8B interface. On load the following error is issued. For the AV-8BV4 profile, there are a huge number of this type of error.

2021-11-09 09:17:24.1650|ERROR|GadrocsWorkshop.Helios.HeliosSerializer|Binding source trigger "Master Arm Panel_Master Arm.Master Arm Panel_Master Arm.position.changed" not found at path "Visual;Monitor 1.Master Arm Panel.Master Arm Panel_Master Arm;Helios.Base.ToggleSwitch;Master Arm Panel_Master Arm"|
2021-11-09 09:17:24.1650|WARN|GadrocsWorkshop.Helios.HeliosSerializer|Dangling binding discarded on Profile load|

This binding was bound prior to 1.6.5011.

@BlueFinBima BlueFinBima changed the title Broken AV-8B Composite gauges broken at 1.6.5011 AV-8B Composite gauges broken at 1.6.5011 Nov 9, 2021
@BlueFinBima BlueFinBima self-assigned this Nov 9, 2021
@BlueFinBima BlueFinBima added the bug Something isn't working label Nov 9, 2021
@BlueFinBima
Copy link
Author

BlueFinBima commented Nov 9, 2021

TriggerID for autobound HeliosValue triggers are no longer matching the dictionary key check in the binding deserializer due to duplicated prefixes on the TriggerID. The TriggerID is being changed asynchronously, and appears to be triggered by the action.Device = device; at line 355 in CompositeVisual.cs. I guess it is part of the processing in HeliosObjectCollection / KeyedObservableCollection
Probably was working badly prior to a refactoring.
More work needed.

@BlueFinBima
Copy link
Author

Notes: Problem was introduced by the changes to UpdateId() in HeliosValue.cs and HeliosTrigger.cs in Commit 661c7e8 .

BlueFinBima added a commit that referenced this issue Nov 10, 2021
…t be found due to duplicated prefixes on the TriggerID for autobound components.
@derammo derammo added this to the Hotfix milestone Nov 12, 2021
@BlueFinBima
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants