Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Source Code Pro font not working properly #3972

Closed
jsgv opened this issue Apr 27, 2021 · 9 comments
Closed

Source Code Pro font not working properly #3972

jsgv opened this issue Apr 27, 2021 · 9 comments

Comments

@jsgv
Copy link

jsgv commented Apr 27, 2021

After the switch from adobe fonts to google fonts for Source Code Pro it reintroduced a similar bug that had happened before. Text shows no color.
5980799#diff-d3fce192d394c65db3038c0da2aafceb4550fa374d7c2ce0a86e43d220f8c7fe
5d66fbd#diff-d3fce192d394c65db3038c0da2aafceb4550fa374d7c2ce0a86e43d220f8c7fe

Reference:
#2639

Original issue on adobe repo that got patched:
adobe-fonts/source-code-pro#250

Working
working

Not working
not-working

@iandol
Copy link
Contributor

iandol commented Apr 27, 2021

Unfortunately, the google versions are old and do not contain many fixes and updates. The PR to restructure the names: #3898 led to an understandable decision to remove all adobe fonts (#3903) and they got replaced with the older Google ones. Personally this regression is worse than the annoyance of the changed names, as while it is possible to substitute font names easily, having to deal with finding completely new fonts for missing glyphs or working round the bugs fixed over the past few years is a harder proposition.

It is hard work for the maintainers that keep homebrew running, and I appreciate their hard work dealing with unsympathetic Corporations like Adobe, so I respect their choices and I think if the brew versions of these fonts don't work for you, we endusers should probably just manually manage Adobe fonts (I've removed the brew versions and manually updated already). But if there was a better solution that would be great!

@carlocab
Copy link
Member

You can try hosting the removed fonts in your own tap. Here are some docs to help you get started:

https://docs.brew.sh/Taps
https://docs.brew.sh/Interesting-Taps-and-Forks
https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

This tap might also be a good candidate for inclusion in the list at https://docs.brew.sh/Interesting-Taps-and-Forks.

@vitorgalvao
Copy link
Member

You can try hosting the removed fonts in your own tap.

That was going to be my suggestion. That’s the way to go in this case, or convince Google Fonts to merge the current PRs.

@hcguersoy
Copy link

Same issue here.

But closing the issue with a "try hosting yourself" is IMHO not the expected answer nor a solution.

IMHO this issue should be reopened until it is fixed.
Or remove it completely but not offer something broken.

@carlocab
Copy link
Member

I'm sorry, but I didn't realise we were obligated to give expected answers. Could you tell me how we came to incur this obligation?

@hcguersoy
Copy link

I didn't tell that you or someone else was "obligated" to do something. I just told you my expectations.
And I have not yet realised that the homebrew community has changed to a two class society: "members" and "users".
Cannot understand your answer otherwise.

I would suggest to remove something broken (in this case this font) or fix it.
If you are not able to fix it, which should be case here due to the broken upstream stuff, remove it.

@carlocab
Copy link
Member

carlocab commented Apr 27, 2021

Yes, but why are your expectations even relevant here? It seems as if your expectations should form some sort of impetus for us to act. Cannot understand your answer otherwise.

I would suggest that you consider how much work you're asking other people to do for you. If you want something done, please either:

  • open a pull request so it can be reviewed; or,
  • contribute to hosting the fonts you need in an external tap.

@vitorgalvao
Copy link
Member

And I have not yet realised that the homebrew community has changed to a two class society: "members" and "users".

I have no idea what you’re going on about. Are you talking about the badges on the comments? That’s a GitHub automatic feature, we have no control over it. It indicates that @carlocab is a maintainer in the Homebrew organisation so users know, it has nothing to do with a “class society”.

I’m locking this because you’re coming off as combative and I’d rather not escalate further. Especially since you’ve never contributed with either code or discussion before, you shouldn’t be making demands on how to run the project.

It’s always the user with a short contributions graph which come guns blazing. That’s the kind of attitude that burns out open-source developers. We are volunteers running for free a project you benefit from in our spare time. I’m not even asking for gratitude, but a little consideration would be nice.

@Homebrew Homebrew locked and limited conversation to collaborators Apr 27, 2021
@vitorgalvao
Copy link
Member

Note: in the past I used to never lock issues in these situations, because I thought it was unfair to not let the other person reply and possibly apologise publicly.

But after years of that strategy bearing no fruit, I realised it is unfair to myself, other maintainers, and the respectful users to not do what I can to preserve our mental sanity, which we need to run a project of this magnitude.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants