Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qlcolorcode for m1 on arm64 #124744

Closed
wants to merge 1 commit into from

Conversation

eduardbosch
Copy link
Contributor

@eduardbosch eduardbosch commented Jun 2, 2022

Update the QlColorCode cask for Apple M1 chipset.
The original repository does not support the M1 chipset but in this discussion @jpc has fixed it

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be a new cask, it's a very confusing concept to pick a different vendor based on the cpu architecture.

@bevanjkay bevanjkay added the awaiting user reply Issue needs response from a user. label Jun 4, 2022
@miccal
Copy link
Member

miccal commented Jun 4, 2022

Thank you @eduardbosch, but please submit this as a separate Cask following our toke reference rules for conflicting names, thanks.

@miccal miccal closed this Jun 4, 2022
@miccal miccal removed the awaiting user reply Issue needs response from a user. label Jun 4, 2022
@eduardbosch
Copy link
Contributor Author

Sorry @SMillerDev @miccal

Thanks for pointing out how to upload this cask ❤️

I've opened a new PR #124931

@massisenergy
Copy link

That should be a new cask, it's a very confusing concept to pick a different vendor based on the cpu architecture.

Currently it's jpc-qlcolorcode, and good work but something like qlcolorcode-m1 (or m1-qlcolorcode) is much more friendly to end user like me.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants