Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chime 2.2.5 (new cask) #174339

Merged
merged 3 commits into from
May 20, 2024
Merged

Chime 2.2.5 (new cask) #174339

merged 3 commits into from
May 20, 2024

Conversation

nestingBiscuit
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Casks/c/chime.rb Outdated
url "https://updates.chimehq.com/com.chimehq.Edit/release/appcast.xml"
strategy :sparkle

# Alternate method to get the version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the alternative in the comments

Casks/c/chime.rb Outdated Show resolved Hide resolved
@krehel
Copy link
Member

krehel commented May 20, 2024

Seems fine to me! ✅

@bevanjkay bevanjkay merged commit 6e6e6e7 into Homebrew:master May 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants