Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drogon 1.9.0 (new formula) #152693

Merged
merged 2 commits into from
Dec 7, 2023
Merged

drogon 1.9.0 (new formula) #152693

merged 2 commits into from
Dec 7, 2023

Conversation

ken-matsui
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core autosquash Automatically squash pull request commits according to Homebrew style. and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Oct 29, 2023
@ken-matsui ken-matsui marked this pull request as draft October 29, 2023 07:17
Formula/d/drogon.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

  ==> cmake -B build
  Failed to execute: cmake
  Error: drogon: failed
  An exception occurred within a child process:

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Nov 22, 2023
Formula/d/drogon.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Nov 24, 2023
@ken-matsui
Copy link
Contributor Author

@SMillerDev Thanks for your reviews!

@ken-matsui ken-matsui marked this pull request as ready for review November 24, 2023 07:23
@chenrui333 chenrui333 removed the test failure CI fails while running the test-do block label Nov 29, 2023
@chenrui333 chenrui333 added the audit failure CI fails while auditing the software label Nov 29, 2023
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
@chenrui333 chenrui333 removed the audit failure CI fails while auditing the software label Dec 6, 2023
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 7, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 7, 2023
Merged via the queue into Homebrew:master with commit 81c191d Dec 7, 2023
12 checks passed
@ken-matsui ken-matsui deleted the drogon branch December 7, 2023 20:05
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants