-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-machine-driver-hyperkit: deprecate as it is unmaintained #82122
Conversation
Thanks @andig. Please use Homebrew/core style when writing your commit messages, like so:
(or similar) |
Just curious, do you have any information about this being unmaintained? |
I've checked the latest commits, see my comment above. Relying on dep in 2021 is unmaintained imho.
@carlocab could you change these when squashing the commits this time? Will do in future... |
Thanks, just wanted to understand your rationale. Since it still seems to be getting a lot of use:
I do agree that building with |
|
We should verify first that it is impossible to build this without |
Only has
but why should we? It is unmaintained and has already caused pain during the go 1.16 cycle. |
Because almost 500 people install it every month. Unless there is no way to fix this these people expect Homebrew packages to keep working. |
I fully understand. However, it is an abandoned product. If people keep expecting it to work they will have to face final breakdown sooner or later. You can keep it half-alive by patching everything in Homebrew or fork the repo and adopt the necessary changes at the root. I'm personally using Homebrew for simplicity of use. My personal preference would be not fixing outdated stuff where it hinders staying up to date with current releases, unless it can be done upstream. This is of course personal taste. Happy to have this PR closed for a better solution. |
I've pinged upstream to resolve the current situation in an appropriate manner. Let's see what happens. |
So we patch it and mark it deprecated, and next Go release we could drop it completely. Since people will have had some warning. |
Will update with patch |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?