Bitcoin circuit support #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inger-lib into rc/audit_chain
There was a problem hiding this comment.
Considering the previous reviews on this PR as well as on the variable base mul_bits() that has been merged into, there is not much to add.
Maybe it'd worth to do some restructuring of group gadgets? It seems that group_test() and group_test_with_add_incomplete() could be merged, and mulbits_test() might be applicable to non-native group gadgets, too.
doc78
approved these changes
Oct 5, 2021
UlrichHaboeck75
approved these changes
Oct 6, 2021
…ginger-lib into optimized_fb_sm
…_fixed_base_inputs`
Hopwood Optimized Fixed-Base Scalar Multiplication
albertog78
reviewed
Nov 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides capabilities to verify statements related to Bitcoin crypto; namely: