Endo #128
Merged
Endo #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the branch sage_scripts_params there are new checks regarding endo_mul in check_curve_parameters.sage
DDT92
reviewed
Oct 12, 2021
There was a problem hiding this comment.
In my opinion now, at least from a mathematical point of view, everything is fine: endo_mul needs 3.5 constraints per bit. I checked also the consistency of the new parameters ENDO_COEFF and ENDO_SCALAR.
I do not know what is the reason of the failing check (https://github.com/HorizenOfficial/ginger-lib/runs/3851741018).
DanieleDiBenedetto
requested changes
Oct 27, 2021
DanieleDiBenedetto
requested changes
Oct 27, 2021
r1cs/gadgets/std/src/groups/curves/short_weierstrass/short_weierstrass_jacobian.rs
Show resolved
Hide resolved
…. Now the lattice test is necessary and sufficient for the injectivity.
…. Now the lattice test is necessary and sufficient for the injectivity.
…. Now the lattice test is necessary and sufficient for the injectivity.
DanieleDiBenedetto
changed the base branch from
rc/audit_chain
to
development
DanieleDiBenedetto
changed the base branch from
development
to
rc/audit_chain
DanieleDiBenedetto
changed the base branch from
rc/audit_chain
to
development
DanieleDiBenedetto
approved these changes
Oct 28, 2021
UlrichHaboeck75
suggested changes
Nov 2, 2021
There was a problem hiding this comment.
Besides that some conflicts in the parameter testing script need to be resolved, everything is fine.
We could further reduce code duplication by giving a default implementation of the EndoMulCurve trait. Not knowing of any other endomorphism-based algorithm in our scope of work, I believe that this would not conflict a generic attitude.
UlrichHaboeck75
approved these changes
Nov 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endomorphism implementation for native algebra end gadget