Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Linux identified as Linux #1

Closed
adjagu opened this issue Jun 19, 2017 · 5 comments
Closed

Arch Linux identified as Linux #1

adjagu opened this issue Jun 19, 2017 · 5 comments
Labels
bug 🐛 A real glitch has been found

Comments

@adjagu
Copy link
Collaborator

adjagu commented Jun 19, 2017

In the following screenshot you can see that Archey4 and lsb_release -d both return Arch Linux. This being the case why does Archey4 display the Linux penguin graphic instead of the Arch Linux one?

screenshot_2017-06-18_20-09-20

@HorlogeSkynet
Copy link
Owner

HorlogeSkynet commented Jun 19, 2017

Oh... That's so sad. Actually, I haven't tested it against a x86 Arch ; I was waiting for someone does 😄

The script uses the output of lsb_release -i -s, could you give me what you have on your system ? Thank you !

@HorlogeSkynet HorlogeSkynet added the bug 🐛 A real glitch has been found label Jun 19, 2017
@adjagu
Copy link
Collaborator Author

adjagu commented Jun 19, 2017

lsb_release -i -s returns Arch.

lsb_release -d -s returns "Arch Linux".

lsb_release -a returns

LSB Version: 1.4
Distributor ID: Arch
Description: Arch Linux
Release: rolling
Codename: n/a

Arch Linux doesn't normally use lsb_release. Arch Linux does always make use of /etc/{os,arch}-release.

cat /etc/arch-release returns Arch Linux release.

@HorlogeSkynet
Copy link
Owner

I see, it is acting pretty weird indeed. On another system I've got an Arch Linux ARM, and the output is the expected Arch Linux with the -i option though.

Tomorrow I'll start to consider this very case (with another improvement on the same idea too), stay tuned 👌
Thanks again for the feedback

@HorlogeSkynet
Copy link
Owner

HorlogeSkynet commented Jun 20, 2017

@adjagu Okay, I've changed the distribution detection stuff among others things, tell me if everything is okay with your system now !

And... don't forget to close this issue if you think it deserves it 😉

@adjagu
Copy link
Collaborator Author

adjagu commented Jun 20, 2017

@HorlogeSkynet It works as expected now and displays proper logo and information. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 A real glitch has been found
Development

No branches or pull requests

2 participants