Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Change the Color from the Output #109

Closed
mrcsdl opened this issue Feb 6, 2022 · 5 comments
Closed

[FEATURE] Change the Color from the Output #109

mrcsdl opened this issue Feb 6, 2022 · 5 comments
Assignees
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Milestone

Comments

@mrcsdl
Copy link

mrcsdl commented Feb 6, 2022

Describe the solution you'd like

The possibility to adjust the color of the font of the output. Maybe in the Config file with hex color codes or something like that.
Something like
Default
[RED]Hostname: [White]Homeserver
Custom
[Cyan]Hostname: [Yellow]Homeserver

@HorlogeSkynet
Copy link
Owner

Hi @mrcsdl

Entries color is currently being "inherited" from logo (the "first" one of the colors palette). May I assume you only want to override this one, and not logo ones ?
If so, yes it could be achieved from configuration.

I have one more question though : how are we supposed to handle OS-RELEASE's ANSI_COLOR with such a new setting ?
(At the moment, this setting overrides the whole packaged colors palette, so logo and entries colors)

  • Proposal 1 : new color setting overrides ANSI_COLOR globally (logo + entries)
  • Proposal 2 : new color setting only overrides entries color (logo color would honor ANSI_COLOR, and entries color would honor new setting)

What do you think about this ?

Feel free to tell me I misunderstand your feature request.
Bye 👋

@HorlogeSkynet HorlogeSkynet self-assigned this Feb 6, 2022
@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Feb 6, 2022
@mrcsdl
Copy link
Author

mrcsdl commented Feb 6, 2022

Proposal 2 sounds awesome that's actually what I mean.

I just want to customize it a bit. That it matches to the rest of my bash

@HorlogeSkynet
Copy link
Owner

Hey @mrcsdl, please see #110 and tell me whether the implementation fits your needs !
Closing here as PR is on its way.

@mrcsdl

This comment was marked as duplicate.

@HorlogeSkynet
Copy link
Owner

Hey @mrcsdl, this feature has just been released as v4.13.4 ! Bye 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Projects
Status: DONE
Development

No branches or pull requests

2 participants