Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Very verbose GPU output #111

Closed
CIAvash opened this issue Mar 28, 2022 · 5 comments · Fixed by #113
Closed

[BUG] Very verbose GPU output #111

CIAvash opened this issue Mar 28, 2022 · 5 comments · Fixed by #113
Assignees
@HorlogeSkynet
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones won't be fixed 💔 This issue won't be fixed (see comments for further explanations)
Milestone
v4.14.0.0

Comments

@CIAvash
Copy link

CIAvash commented Mar 28, 2022

Describe the bug
The output of GPU entry for AMD 6900 XT is very verbose. It shows:

GPU: Advanced Micro Devices, Inc. [AMD/ATI] Navi 21 [Radeon RX 6800/6800 XT / 6900 XT] (rev c0)

Expected behavior
More concise GPU output, for example, neofetch shows this:

GPU: AMD ATI Radeon RX 6800/6800 XT / 6900 XT

Environment

  • Version used (4.Y.Z) : 4.13.4
  • Method of installation (distribution package, PyPI, Homebrew, sources) : AUR
  • Hardware type (laptop, server, Raspberry, hyper-visor) : Desktop
  • Python version (3.Y.Z) : 3.10.3
  • Operating system and version : Arch Linux (Linux 5.16.16-arch1-1)
  • Graphical environment name and version : Sway window manager
  • Connectivity (off-line, LAN only, Internet access) : Internet
@HorlogeSkynet
Copy link
Owner

Hi @CIAvash

It's true that Archey does not assume anything about GPU data format, and simply shows it all (ref).
On the other hand, Neofetch performs extended parsing, and specifically for your GPU (ref).

I don't really know what we should/could do about it here, because looking at Neofetch code, this really looks like vendor-related parsing (which I'd rather avoid, because of the maintaining burden).

I'm opened to any idea though, including changing or preferring another data source on GNU/Linux platforms.

Cheers 👋

@HorlogeSkynet HorlogeSkynet added enhancement ⬆️ Implements a new feature, fixes or improves existing ones help wanted 🆘 This issue needs someone else ! Maybe you ? labels Mar 28, 2022
@CIAvash
Copy link
Author

CIAvash commented Mar 29, 2022

hwinfo shows a shorter output:

hwinfo --short | rg -A 1 'graphics card:' | sd '\s+' ' '
graphics card: ATI Navi 21 [Radeon RX 6800/6800 XT / 6900 XT]

lshw:

lshw -C display 2>/dev/null | rg product
product: Navi 21 [Radeon RX 6800/6800 XT / 6900 XT]

That said, how about adding a field to run custom commands? For example a custom_command field. Or even better allow adding custom entries in which users can run custom commands. What do you think?

@HorlogeSkynet
Copy link
Owner

Thanks for your command outputs.

That said, how about adding a field to run custom commands? For example a custom_command field. Or even better allow adding custom entries in which users can run custom commands. What do you think?

Definitely, I wanted to (more or less) implement something like this in a rather far future, but I'll try to come up with something sooner then 🙇

@HorlogeSkynet HorlogeSkynet self-assigned this Mar 29, 2022
HorlogeSkynet pushed a commit that referenced this issue May 8, 2022
[CORE] Adds support for custom entries
0dc2b39 
This patch brings a first support for "custom entries" to Archey. It
mainly allows users to run custom commands through their configuration
file.

In order to give "power to the user" for most of situations:
* STDERR output **MAY** be silenced through `log_stderr` option
* command exit status code **MAY** be ignored through `check` option

Multi-lines results will be joined on the same line, unless `one_line`
option is disabled.

Users **SHOULD** only enable `shell` option if they have to.

> See #111 for rationale.
@HorlogeSkynet HorlogeSkynet mentioned this issue May 8, 2022
Merged
6 tasks
@HorlogeSkynet HorlogeSkynet linked a pull request May 8, 2022 that will close this issue
[CORE] Adds support for custom entries #113
Merged
6 tasks
@HorlogeSkynet
Copy link
Owner

Hi @CIAvash, please tell me if #113 implementation draft fits your needs 🙏

@CIAvash
Copy link
Author

CIAvash commented May 8, 2022

Hi @HorlogeSkynet, yes, it works perfectly. Thanks!

@HorlogeSkynet HorlogeSkynet added won't be fixed 💔 This issue won't be fixed (see comments for further explanations) and removed help wanted 🆘 This issue needs someone else ! Maybe you ? labels May 21, 2022
@HorlogeSkynet HorlogeSkynet added this to the v4.14.0.0 milestone Sep 8, 2022
@HorlogeSkynet HorlogeSkynet mentioned this issue Jan 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HorlogeSkynet HorlogeSkynet

Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones won't be fixed 💔 This issue won't be fixed (see comments for further explanations)
Projects
Archey4 - Core
Status: DONE
Milestone
v4.14.0.0
Development

Successfully merging a pull request may close this issue.

[CORE] Adds support for custom entries HorlogeSkynet/archey4
2 participants
@CIAvash @HorlogeSkynet