Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOGO][macOS] Updates "retro" style to a cleaner one #99

Merged
merged 4 commits into from
May 5, 2021
Merged

[LOGO][macOS] Updates "retro" style to a cleaner one #99

merged 4 commits into from
May 5, 2021

Conversation

GentleHoneyLover
Copy link
Contributor

@GentleHoneyLover GentleHoneyLover commented Apr 27, 2021

I think this logo (from original archey) is much cleaner and slicker ;)

see #98.

I think this logo (from original archey) is much cleaner and slicker ;)
@GentleHoneyLover
Copy link
Contributor Author

This is how it'll look like:

Screen Shot 2021-04-27 at 21 18 11

@HorlogeSkynet
Copy link
Owner

Thanks for the PR ! I don't mind you editing the new "retro" one (not yet published), but I would rather you don't change the "default" one, without proper reviews from other users. From relatives, it corresponds well the way it is. Bye 👋

@GentleHoneyLover
Copy link
Contributor Author

@HorlogeSkynet, you're the boss :)) Updating just the retro one is fine for me...

Should I open a new PR for that?

@HorlogeSkynet
Copy link
Owner

Great 👌 you may only add a commit to your own branch, it would update this PR automatically !

@HorlogeSkynet HorlogeSkynet changed the title Update logo to a cleaner one [LOGO][macOS] Update "retro" style to a cleaner one Apr 28, 2021
@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Apr 28, 2021
@HorlogeSkynet HorlogeSkynet linked an issue Apr 28, 2021 that may be closed by this pull request
archey/logos/darwin.py Outdated Show resolved Hide resolved
archey/logos/darwin.py Outdated Show resolved Hide resolved
@HorlogeSkynet HorlogeSkynet changed the title [LOGO][macOS] Update "retro" style to a cleaner one [LOGO][macOS] Updates "retro" style to a cleaner one May 5, 2021
@HorlogeSkynet HorlogeSkynet merged commit 12c4f3a into HorlogeSkynet:master May 5, 2021
@parkerbxyz
Copy link

👋 Can this option (--logo-style) be set in a configuration file so it doesn't have to be included as an argument each time?

@HorlogeSkynet
Copy link
Owner

Hi @parkerbxyz, yes it could. I'll add this to the TODO-list.

@ingrinder
Copy link
Collaborator

See #124 - I would attach it to the card in projects but I'm not entirely sure how...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] ASCII art and entries aren't colored
4 participants