Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin & Feedback] Optional talk start/end date time #730

Merged
merged 5 commits into from
May 21, 2020

Conversation

HugoGresse
Copy link
Owner

@HugoGresse HugoGresse commented May 21, 2020

Fix #659

  • talk dates are now optional
  • Feedback: if all talks are without dates, hide the date selection on the feedback app & display them from the root (example.com/mytalk) without the day at the end. This get one step closer to Make urls prettier using a slug instead of ids #535
  • Feedback: if one talk or more has no dates but others has, display a "Without date" in the menu, selected by default
  • Admin: date time picker is now a dialog with a Clear/Cancel/OK button inside
  • Admin: date time field no longer show autocomplete help

Eg event with some talks without dates
Capture d’écran 2020-05-21 à 13 00 03

eg event with no date on talks
Capture d’écran 2020-05-21 à 13 00 23

@HugoGresse HugoGresse added enhancement New feature or request admin app Admin app (openfeedback.io/admin) feedback app Feedback related issue labels May 21, 2020
@HugoGresse HugoGresse self-assigned this May 21, 2020
@cypress
Copy link

cypress bot commented May 21, 2020



Test summary

7 0 0 0


Run details

Project open-feedback
Status Passed
Commit 7cf3a20
Started May 21, 2020 12:22 PM
Ended May 21, 2020 12:23 PM
Duration 01:13 💡
OS Linux Ubuntu Linux - 16.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@HugoGresse HugoGresse merged commit 3396d30 into master May 21, 2020
@HugoGresse HugoGresse deleted the admin-optional-talk-date-659 branch May 21, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin app Admin app (openfeedback.io/admin) enhancement New feature or request feedback app Feedback related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Admin & Feedback] Make talk date optional
1 participant