Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contours seem to be incorrect #128

Closed
tdelhomme opened this issue Jun 2, 2016 · 1 comment
Closed

Contours seem to be incorrect #128

tdelhomme opened this issue Jun 2, 2016 · 1 comment
Assignees
@tdelhomme
Labels
minor bug
Milestone
v1.0

Comments

@tdelhomme
Copy link
Member

See following example.
An orange dot cut the yellow line.

chr12_25398284_25398284_c_a
@tdelhomme tdelhomme added this to the v1.0 milestone Jun 2, 2016
@tdelhomme tdelhomme self-assigned this Jun 2, 2016
tdelhomme added a commit that referenced this issue Jun 2, 2016
@tdelhomme
correct contours plot with BH qvalues computation
023dade 
`p.adjust()` from R compute by default the Bonferroni correction, but in our model we use the Benjamini-Hochberg one.
fixes #128
tdelhomme referenced this issue Jun 3, 2016
@tdelhomme
Update needlestack.r
39385a8
@mfoll
Copy link
Member

mfoll commented Jun 3, 2016 •
edited
Loading

Also contour colours are only approximately correct. Fixed in 1633c53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdelhomme tdelhomme

Labels
minor bug
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@mfoll @tdelhomme