Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in Job condition check #74

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

pit1sIBM
Copy link
Contributor

@pit1sIBM pit1sIBM commented May 24, 2024

Related Issue

Supports #ISSUE_NUMBER

Related PRs

#64

What this PR does / why we need it

Change Completed to Complete because otherwise verify checks don't work 😞

 ❯ kjobs docproc-create-bucket -o yaml | yq '.status.conditions'
- lastProbeTime: "2024-05-24T05:14:39Z"
  lastTransitionTime: "2024-05-24T05:14:39Z"
  status: "True"
  type: Complete

Special notes for your reviewer

If applicable**

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

What gif most accurately describes how I feel towards this PR?

Example of a gif

@pit1sIBM
Copy link
Contributor Author

Failures from the test appear unrelated to my changes, or am I missing something?

FAIL Required test coverage of 85.0% not reached. Total coverage: 84.86%
=========================== short test summary info ============================
FAILED tests/test_setup_vcs.py::test_setup_vcs_with_defaults - AttributeError...
FAILED tests/test_setup_vcs.py::test_setup_vcs_branches - AttributeError: '_p...
FAILED tests/test_setup_vcs.py::test_setup_vcs_some_of_each - AttributeError:...
FAILED tests/test_setup_vcs.py::test_setup_vcs_force - AttributeError: '_pygi...
FAILED tests/test_vcs.py::test_create_worktree_exceptions - oper8.vcs.VCSRunt...
=================== 5 failed, 833 passed in 91.96s (0:01:31) ===================

oper8/verify_resources.py Outdated Show resolved Hide resolved
@pit1sIBM pit1sIBM force-pushed the fix-job-typo branch 2 times, most recently from 4995433 to dadd918 Compare May 24, 2024 13:40
Copy link
Collaborator

@HonakerM HonakerM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HonakerM
Copy link
Collaborator

@pit1sIBM it looks like you're getting unlucky. pygit2 released a new version and now we're breaking. I can opened another PR to pin it to under 1.15.0

@HonakerM
Copy link
Collaborator

PR opened: #75

Signed-off-by: Zac Pitones <zac.pitones@ibm.com>
@gabe-l-hart gabe-l-hart merged commit f704b83 into IBM:main May 24, 2024
6 checks passed
@pit1sIBM pit1sIBM deleted the fix-job-typo branch May 24, 2024 17:19
@pit1sIBM
Copy link
Contributor Author

Thanks @HonakerM @gabe-l-hart sorry for the trouble

@gabe-l-hart
Copy link
Collaborator

Not a problem, thanks for the fix!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants