Skip to content

Commit

Permalink
Merge pull request #1294 from Shopify/go112-ci
Browse files Browse the repository at this point in the history
Add support for Golang 1.12
  • Loading branch information
bai committed Feb 26, 2019
2 parents 0cfd4e6 + ca31ca3 commit 6bc31ae
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ language: go
go:
- 1.10.x
- 1.11.x
- 1.12.x

env:
global:
Expand All @@ -11,9 +12,8 @@ env:
- KAFKA_HOSTNAME=localhost
- DEBUG=true
matrix:
- KAFKA_VERSION=1.1.1 KAFKA_SCALA_VERSION=2.11
- KAFKA_VERSION=2.0.1 KAFKA_SCALA_VERSION=2.12
- KAFKA_VERSION=2.1.0 KAFKA_SCALA_VERSION=2.12
- KAFKA_VERSION=2.1.1 KAFKA_SCALA_VERSION=2.12

before_install:
- export REPOSITORY_ROOT=${TRAVIS_BUILD_DIR}
Expand All @@ -27,7 +27,7 @@ script:
- make test
- make vet
- make errcheck
- if [[ "$TRAVIS_GO_VERSION" == 1.11* ]]; then make fmt; fi
- if [[ "$TRAVIS_GO_VERSION" == 1.12* ]]; then make fmt; fi

after_success:
- bash <(curl -s https://codecov.io/bash)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ You might also want to look at the [Frequently Asked Questions](https://github.c
Sarama provides a "2 releases + 2 months" compatibility guarantee: we support
the two latest stable releases of Kafka and Go, and we provide a two month
grace period for older releases. This means we currently officially support
Go 1.8 through 1.11, and Kafka 1.0 through 2.0, although older releases are
Go 1.10 through 1.12, and Kafka 2.0 through 2.2, although older releases are
still likely to work.

Sarama follows semantic versioning and provides API stability via the gopkg.in service.
Expand Down
2 changes: 1 addition & 1 deletion dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: sarama

up:
- go:
version: '1.11'
version: '1.12'

commands:
test:
Expand Down

0 comments on commit 6bc31ae

Please sign in to comment.