Merge pull request #2171 from Shopify/fix-version-race

fix: potential data race on a global variable
IBM · Mar 7, 2022 · 7b9f4c6 · 7b9f4c6
2 parents 3f90bc7 + 3c7163e
commit 7b9f4c6
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/version.go b/version.go
@@ -1,11 +1,17 @@
 package sarama
 
-import "runtime/debug"
+import (
+	"runtime/debug"
+	"sync"
+)
 
-var v string
+var (
+	v     string
+	vOnce sync.Once
+)
 
 func version() string {
-	if v == "" {
+	vOnce.Do(func() {
 		bi, ok := debug.ReadBuildInfo()
 		if ok {
 			v = bi.Main.Version
@@ -15,6 +21,6 @@ func version() string {
 			// the version
 			v = "dev"
 		}
-	}
+	})
 	return v
 }