fix(test): use Sarama transactional producer #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏼 Is this still something we want? |
|
Yes probably. The intention was that we'd do away with using a third party jar to test out transactional messages and instead we'd use our own transactional producer to generate them, but I only partially started implementing it and never got back to finishing it off :) |
|
Cool, thanks thank makes sense. I've been going through some PRs here to clean things up a bit and was curious about this one. |
dnwe
force-pushed
the
dnwe/fvtx
branch
3 times, most recently
from
480a548
to
1de9f7e
Compare
|
I don't really use Sarama much these days anymore (I've moved to a Ruby team) but even so I'm still delighted to see the back of that jar 😂 |
This was referenced Feb 24, 2022
This was referenced Apr 19, 2022
fix(deps): update module github.com/shopify/sarama to v1.32.0
secustor/opentelemetry-meetup#41
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the pieces of #1695 was to use a small jar for publishing
uncommited messages as part of the functional test. Replacing that with
the native Sarama transactional producer
Fixes #1733
Co-authored-by: @KJTsanaktsidis